Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-proton-j/pull/18#discussion_r225224724 --- Diff: examples/reactor/src/main/java/org/apache/qpid/proton/example/reactor/EchoInputStreamWrapper.java --- @@ -31,11 +31,12 @@ public class EchoInputStreamWrapper extends Thread { + private static final AtomicInteger idCounter = new AtomicInteger(); --- End diff -- I don't think this really needed fixed and would have just left it as is. Its only an example, likely to count to 1. Typically having a static shared between reactors would often be incorrect. If it were to change the variable name would be of the wrong syntax.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org