kgiusti commented on a change in pull request #445: DISPATCH-1246: clean up
core link endpoints on shutdown
URL: https://github.com/apache/qpid-dispatch/pull/445#discussion_r252750736
##########
File path: src/router_core/connections.c
##########
@@ -1227,9 +1223,7 @@ static void qdr_connection_closed_CT(qdr_core_t *core,
qdr_action_t *action, boo
qdr_connection_work_t *work = DEQ_HEAD(conn->work_list);
while (work) {
DEQ_REMOVE_HEAD(conn->work_list);
- qdr_terminus_free(work->source);
- qdr_terminus_free(work->target);
- free_qdr_connection_work_t(work);
+ qdr_connection_work_free_CT(work);
Review comment:
I have a theory - more like a wild*ss guess - on why that abort() call may
be in error. Testing now.
That use after free is scary: a link work item is being accessed by the core
thread after being freed by an I/O thread. I wonder if the peer link's work
should only be accessed under the conn_lock?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
