[
https://issues.apache.org/jira/browse/DISPATCH-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780378#comment-16780378
]
ASF GitHub Bot commented on DISPATCH-1273:
------------------------------------------
codecov-io commented on issue #452: DISPATCH-1273: enforce target policy for
anonymous senders
URL: https://github.com/apache/qpid-dispatch/pull/452#issuecomment-468231203
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=h1)
Report
> Merging
[#452](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e94c5cf6f98083af3066b8cff2fd5aa0b176027?src=pr&el=desc)
will **increase** coverage by `0.03%`.
> The diff coverage is `87.87%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 86.8% 86.84% +0.03%
==========================================
Files 85 85
Lines 18756 18787 +31
==========================================
+ Hits 16282 16315 +33
+ Misses 2474 2472 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `94.15% <100%> (+0.06%)` | :arrow_up: |
|
[src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3BvbGljeS5j)
| `85.29% <80.95%> (-0.16%)` | :arrow_down: |
|
[...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==)
| `92.67% <0%> (-1.28%)` | :arrow_down: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `63.84% <0%> (-0.57%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `93.45% <0%> (-0.22%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.63% <0%> (+0.12%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `78.31% <0%> (+0.18%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `88.54% <0%> (+0.25%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `91.21% <0%> (+0.43%)` | :arrow_up: |
| ... and [2
more](https://codecov.io/gh/apache/qpid-dispatch/pull/452/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=footer).
Last update
[8e94c5c...ee82bac](https://codecov.io/gh/apache/qpid-dispatch/pull/452?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 'to' field not authorized against valid targets for anonymous sender
> --------------------------------------------------------------------
>
> Key: DISPATCH-1273
> URL: https://issues.apache.org/jira/browse/DISPATCH-1273
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Gordon Sim
> Priority: Major
>
> With following policy, attempts to attach a sender link to 'bar' will fail as
> expected, but if an anonymous sender is attached and a message is sent to
> 'bar', it gets through.
>
> {noformat}
> [
> ["vhost",
> {
> "id": "$default",
> "allowUnknownUser": true,
> "groups": {
> "$default" : {
> "users": "*",
> "remoteHosts": "*",
> "allowDynamicSource": true,
> "allowAnonymousSender": true,
> "sources": "*",
> "targets": "foo"
> }
> }
> }
> ]
> ]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
