[
https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825230#comment-16825230
]
ASF GitHub Bot commented on DISPATCH-1310:
------------------------------------------
ganeshmurthy commented on pull request #492: DISPATCH-1310: refactor the
receive handler code
URL: https://github.com/apache/qpid-dispatch/pull/492#discussion_r278159983
##########
File path: src/container.c
##########
@@ -642,8 +641,8 @@ void qd_container_handle_event(qd_container_t *container,
pn_event_t *event,
delivery = pn_event_delivery(event);
pn_link = pn_event_link(event);
- if (pn_link_is_receiver(pn_link))
- do_receive(delivery);
+ if (pn_delivery_readable(delivery))
Review comment:
If you look at commit 417975e17406dcc48a648d9fc6da38651a4ff956, the
pn_delivery_readable was changed to pn_link_is_receiver. Please talk to
@ted-ross about this just to make sure we don't have a regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Move delivery settlement and disposition propagation out of the core thread
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-1310
> URL: https://issues.apache.org/jira/browse/DISPATCH-1310
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Affects Versions: 1.6.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Minor
> Labels: delivery-refactor
>
> In the current design all changes to a delivery's disposition and settlement
> state has to move through the core thread.
> Contrast this with the data associated with a delivery (held in the message
> content object) - data is moved between I/O threads without passing through
> the core thread.
> Moving the disposition and settlement state propagation to the I/O threads
> (like delivery data) will simplify its synchronization (2 thread rather than
> 3) and will (likely) improve performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
