[ 
https://issues.apache.org/jira/browse/PROTON-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830729#comment-16830729
 ] 

Cliff Jansen commented on PROTON-2036:
--------------------------------------

Also add a clearer description that

 

  proton::work_queue::xyz()

 

is thread safe, but that obtaining it must be done on the callback thread 
because

 

  proton_obj::work_queue()

 

is not.

It might also help to use a different name for the accessor to the 
application's copy of the work queue to something other than work_queue() in 
the multithreaded example programs.

> Additional C++ threading documentation
> --------------------------------------
>
>                 Key: PROTON-2036
>                 URL: https://issues.apache.org/jira/browse/PROTON-2036
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>    Affects Versions: proton-c-0.27.1
>            Reporter: Cliff Jansen
>            Assignee: Cliff Jansen
>            Priority: Major
>
> The C++ documentation about the threading model should explicitly call out 
> some the the common pitfalls encountered using Proton objects.
> While the obvious method calls are easy to spot and address, the implicit 
> method calls to destructors or copy constructors are much easier to miss.
> Some places where this happens are when embedding proton objects in other 
> classes, passing arguments to method calls or lambda captures.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to