[
https://issues.apache.org/jira/browse/QPID-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831061#comment-16831061
]
ASF GitHub Bot commented on QPID-8294:
--------------------------------------
overmeulen commented on pull request #32: QPID-8294: [Brojer-J][JDBC] Configure
'qpid.jdbcstore.inClauseMaxSize' as context variable
URL: https://github.com/apache/qpid-broker-j/pull/32#discussion_r280101481
##########
File path:
broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/AbstractJDBCMessageStore.java
##########
@@ -230,6 +233,8 @@ public Thread newThread(final Runnable r)
});
_executor.prestartAllCoreThreads();
+ _contextKeys = parent.getContextKeys(false);
+ _inClauseMaxSize = getContextValue(Integer.class, IN_CLAUSE_MAX_SIZE,
IN_CLAUSE_MAX_SIZE_DEFAULT);
Review comment:
You're implicitly setting an order between these 2 lines since
getContextValue uses _contextKeys. Maybe _contextKeys should be a parameter of
getContextValue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Broker-J][Oracle Message Store] Batch delete fails for more than 1000
> messages
> -------------------------------------------------------------------------------
>
> Key: QPID-8294
> URL: https://issues.apache.org/jira/browse/QPID-8294
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.1.0
> Reporter: Olivier VERMEULEN
> Assignee: Alex Rudyy
> Priority: Critical
> Fix For: qpid-java-broker-8.0.0, qpid-java-broker-7.1.3
>
>
> When under high load, the Broker-J can end up having to delete more than 1000
> messages in a single batch. But some databases (and Oracle in particular) put
> a limit to the number of elements you can have in the IN clause. So we end up
> with the following exception: ORA-01795: maximum number of expressions in a
> list is 1000
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
