[ https://issues.apache.org/jira/browse/PROTON-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831072#comment-16831072 ]
ASF subversion and git services commented on PROTON-2029: --------------------------------------------------------- Commit 22705b69bec3f7fb87904ff7873ca158b3f3c3bd in qpid-proton-j's branch refs/heads/master from Robert Gemmell [ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=22705b6 ] PROTON-2029: tweaks #33 to apply the state but only prevent generating the frame, add clarifying doc comment. Retains existing order independence (between output processing) to avoid unlikely but possible breakage of existing uses. > applying delivery state to a locally-settled delivery can cause erroneous > disposition frame > ------------------------------------------------------------------------------------------- > > Key: PROTON-2029 > URL: https://issues.apache.org/jira/browse/PROTON-2029 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j > Affects Versions: proton-j-0.32.0 > Reporter: Robbie Gemmell > Priority: Minor > > If a delivery has disposition state applied and is locally-settled (and the > transport output processed), e.g a consumer receiving an unsettled message > and acknowledging it, then the unexpected act of applying further delivery > state to the delivery object can result in erroneously emitting another > disposition frame upon future processing. > This occurs because applying the state makes adds the delivery to the > transport work list again, with the process only being gated on prior > remote-settlement to prevent sending a useless notice of settlement. It > should also gate on local-settlement to avoid the odd post-settlement state > application from actually leading to a disposition frame. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org