[ 
https://issues.apache.org/jira/browse/PROTON-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851209#comment-16851209
 ] 

ASF subversion and git services commented on PROTON-2057:
---------------------------------------------------------

Commit 3294a4019af6ab4ec0f89fff11bd53a83d8e9788 in qpid-proton-j's branch 
refs/heads/master from Ang Iongchun
[ https://gitbox.apache.org/repos/asf?p=qpid-proton-j.git;h=3294a40 ]

PROTON-2057: fix small/array8 array encodings over 128 bytes

Changes split out from #34 by Ang Iongchun, plus tests from me (Robbie).
See also b666d6a165af7835bde12e0e41de2ca6109126d9.
This closes #34.


> small/array8 primitive arrays >=128 bytes fail to encode
> --------------------------------------------------------
>
>                 Key: PROTON-2057
>                 URL: https://issues.apache.org/jira/browse/PROTON-2057
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: proton-j-0.30.0, proton-j-0.31.0, proton-j-0.32.0, 
> proton-j-0.33.0
>         Environment: OS: RHEL 7.2
> JRE: OpenJDK Runtime Environment (build 1.8.0_102-b14)
> proton-j 0.32.0 and 0.33.0
> qpid-jms-client 0.41.0 and 0.42.0
>            Reporter: Ang Iongchun
>            Assignee: Robbie Gemmell
>            Priority: Major
>             Fix For: proton-j-0.34.0
>
>
> While encoding a small/array8 primitive array with >=128 bytes content (and 
> obviously <=255 bytes given array8 type), an exception will be thrown. The 
> array size is being stored in a byte variable, which can be negative, for 
> later writing out as a raw 1byte size field during the encoding. The value 
> was mistakengly also being used to facilitate checking for buffer capacity or 
> expansion, which can fail due to the potentially negative value if the array 
> is in the appropate size range.
> This was introduced during proton-j 0.30.0 changes for PROTON-1941.
>  
> ================
>  Original Description:
> Receiving a AMQP short array (length less than 256) with qpid-jms-client 
> causes this error in log:
> [AmqpProvider :(1):[amqp://localhost:5672]] WARN o.a.q.j.p.a.AmqpConsumer - 
> Error on transform: minWritableBytes: -92 (expected: >= 0)
> The message is still kept in queue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to