ChugR commented on issue #514: DISPATCH-1349 qd_buffer_list_clone is wasting dst buffers available capacity URL: https://github.com/apache/qpid-dispatch/pull/514#issuecomment-497338659 This is not a general purpose function called for complete messages. This function is called when message routing annotation fields (to_override, trace, ingress) are copied as a message is sent to multiple places. Each field may be overwritten with different information as it is sent to each place; or it may not. My bet is that the vast majority of the copies involve only one buffer. In the event that a copy goes on to a second buffer that buffer will (almost) always hold the rest of the field. The change would coalesce two buffers into one only very rarely. I'm not downvoting this change, just wondering how we could measure the benefit.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
