[
https://issues.apache.org/jira/browse/DISPATCH-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865458#comment-16865458
]
ASF GitHub Bot commented on DISPATCH-1371:
------------------------------------------
codecov-io commented on issue #523: DISPATCH-1371 qd_alloc can reuse instances
in LIFO order
URL: https://github.com/apache/qpid-dispatch/pull/523#issuecomment-502601613
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=h1)
Report
> Merging
[#523](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/b172f501028b36d786b4c83bcee1e195cd17fcf2?src=pr&el=desc)
will **decrease** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
- Coverage 86.9% 86.85% -0.06%
==========================================
Files 87 87
Lines 19514 19519 +5
==========================================
- Hits 16959 16953 -6
- Misses 2555 2566 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL2FsbG9jX3Bvb2wuYw==)
| `98.25% <100%> (ø)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `85% <0%> (-0.79%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.6% <0%> (-0.78%)` | :arrow_down: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.79% <0%> (-0.69%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.45% <0%> (-0.37%)` | :arrow_down: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.53% <0%> (-0.2%)` | :arrow_down: |
|
[...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/523/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j)
| `86.55% <0%> (+1.61%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=footer).
Last update
[b172f50...a1bba08](https://codecov.io/gh/apache/qpid-dispatch/pull/523?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> qd_alloc can reuse instances in LIFO order
> ------------------------------------------
>
> Key: DISPATCH-1371
> URL: https://issues.apache.org/jira/browse/DISPATCH-1371
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Francesco Nigro
> Priority: Minor
>
> qd_dealloc is inserting instances on the tail of the thread local free_list
> while qd_alloc is reading from the head, always causing cache misses unless
> free_list size is 1.
> qd_alloc could instead reuse the last inserted instance ie the tail, using
> free_list as a stack (with LIFO accesses).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
