[
https://issues.apache.org/jira/browse/QPIDJMS-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866388#comment-16866388
]
ASF GitHub Bot commented on QPIDJMS-461:
----------------------------------------
gemmellr commented on pull request #30: QPIDJMS-461 Optimize the default
message ID builder
URL: https://github.com/apache/qpid-jms/pull/30#discussion_r294693305
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/policy/JmsDefaultMessageIDPolicy.java
##########
@@ -26,7 +26,15 @@
*/
public class JmsDefaultMessageIDPolicy implements JmsMessageIDPolicy {
- private JmsMessageIDBuilder messageIDBuilder =
JmsMessageIDBuilder.BUILTIN.DEFAULT.createBuilder();
+ /**
+ * A global builder instance to use instance of allocating one on each
builder get.
Review comment:
The second mention of 'instance' should be 'instead'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JmsMessageIDBuilder::createMessageID can save StringBuilder allocations
> -----------------------------------------------------------------------
>
> Key: QPIDJMS-461
> URL: https://issues.apache.org/jira/browse/QPIDJMS-461
> Project: Qpid JMS
> Issue Type: Improvement
> Affects Versions: 0.44.0
> Reporter: Francesco Nigro
> Priority: Minor
> Attachments: screenshot-1.png
>
>
> JmsMessageIDBuilder::createMessageID doesn't seem able to correctly perform
> escape analysis on StringBuilder, allocating many of them.
> The intermediate StringBuilder could be saved into a thread local pool
> instead, saving unnececessary allocations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
