kgiusti commented on a change in pull request #525: DISPATCH-1372 alloc_pool
intrusive linked list can be replaced by a linked stack
URL: https://github.com/apache/qpid-dispatch/pull/525#discussion_r296759355
##########
File path: src/alloc_pool.c
##########
@@ -164,14 +242,17 @@ void *qd_alloc(qd_alloc_type_desc_t *desc,
qd_alloc_pool_t **tpool)
desc->stats->held_by_threads += desc->config->transfer_batch_size;
#endif
for (idx = 0; idx < desc->config->transfer_batch_size; idx++) {
- item = DEQ_HEAD(desc->global_pool->free_list);
- DEQ_REMOVE_HEAD(desc->global_pool->free_list);
- DEQ_INSERT_TAIL(pool->free_list, item);
+ item = pop_stack(&desc->global_pool->free_list);
Review comment:
Hmmm - totally not thought through, but if CHUNK_SIZE was ==
transfer_batch_size, could we avoid this looping while holding the global pool
lock?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
