franz1981 commented on a change in pull request #525: DISPATCH-1372 alloc_pool 
intrusive linked list can be replaced by a linked stack
URL: https://github.com/apache/qpid-dispatch/pull/525#discussion_r297786059
 
 

 ##########
 File path: src/alloc_pool.c
 ##########
 @@ -164,14 +242,17 @@ void *qd_alloc(qd_alloc_type_desc_t *desc, 
qd_alloc_pool_t **tpool)
         desc->stats->held_by_threads += desc->config->transfer_batch_size;
 #endif
         for (idx = 0; idx < desc->config->transfer_batch_size; idx++) {
-            item = DEQ_HEAD(desc->global_pool->free_list);
-            DEQ_REMOVE_HEAD(desc->global_pool->free_list);
-            DEQ_INSERT_TAIL(pool->free_list, item);
+            item = pop_stack(&desc->global_pool->free_list);
 
 Review comment:
   OK it seems that the original chunk size was good enough, no significant 
improvements

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to