[
https://issues.apache.org/jira/browse/PROTON-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910493#comment-16910493
]
ASF GitHub Bot commented on PROTON-2086:
----------------------------------------
kpvdr commented on pull request #186: PROTON-2086: Changed API documentation
from epydoc to Sphinx
URL: https://github.com/apache/qpid-proton/pull/186#discussion_r315281467
##########
File path: python/proton/utils.py
##########
@@ -19,12 +19,14 @@
from __future__ import absolute_import
-from ._utils import BlockingConnection, SyncRequestResponse, SendException,
LinkDetached, ConnectionClosed
+from ._utils import BlockingConnection, BlockingSender, BlockingReceiver,
SyncRequestResponse, SendException, LinkDetached, ConnectionClosed
__all__ = [
'BlockingConnection',
+ 'BlockingSender',
+ 'BlockingReceiver',
'SyncRequestResponse',
'SendException',
'LinkDetached',
- 'ConnectionClosed'
+ 'ConnectionClosed',
Review comment:
I have thought of this as a style related issue (with certain advantages),
and have seen a trailing comma frequently in use
(https://stackoverflow.com/questions/11597901/why-are-trailing-commas-allowed-in-a-list).
I certainly have no objection removing it, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Move Python API docs to use Sphinx
> ----------------------------------
>
> Key: PROTON-2086
> URL: https://issues.apache.org/jira/browse/PROTON-2086
> Project: Qpid Proton
> Issue Type: Task
> Components: python-binding
> Reporter: Kim van der Riet
> Assignee: Kim van der Riet
> Priority: Major
>
> Currently the Python API docs are generated using ePyDoc. These should be
> switched to using Sphinx.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
