astitcher commented on issue #187: cpp/CMakeLists.txt: fix qpid-proton-cpp linking URL: https://github.com/apache/qpid-proton/pull/187#issuecomment-524436160 Can you explain your specific situation more because this fix doesn't entirely make sense: These libraries should be LINK_PRIVATE as far as cmake semantics are concerned because they provide symbols only to the qpid-proton-cpp library itself and are not needed by any of it's clients. LINK_PUBLIC means that any client of qpid-proton-cpp would need to explicitly link with these libraries and this is not needed or desired. Are you perhaps trying to build the cpp directory of the qpid-proton tree by itself? Currently the only way to build the C++ API is as part of the full tree build.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
