[jira] [Commented] (DISPATCH-1390) qd_buffer_list_clone is copying too much data

Mon, 26 Aug 2019 11:07:09 -0700 


    [ 
https://issues.apache.org/jira/browse/DISPATCH-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916019#comment-16916019
 ] 

ASF GitHub Bot commented on DISPATCH-1390:
------------------------------------------

codecov-io commented on issue #543: DISPATCH-1390 - qd_buffer_list_clone is 
copying too much data
URL: https://github.com/apache/qpid-dispatch/pull/543#issuecomment-513829677
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=h1) 
Report
   > Merging 
[#543](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/f0dae4c5d6ee65fd2a2399e131fa60930d081bc3?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/543/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #543      +/-   ##
   ==========================================
   + Coverage   86.55%   86.55%   +<.01%     
   ==========================================
     Files          88       88              
     Lines       19638    19732      +94     
   ==========================================
   + Hits        16998    17080      +82     
   - Misses       2640     2652      +12
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[include/qpid/dispatch/buffer.h](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-aW5jbHVkZS9xcGlkL2Rpc3BhdGNoL2J1ZmZlci5o)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[src/buffer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL2J1ZmZlci5j)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[tests/buffer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-dGVzdHMvYnVmZmVyX3Rlc3QuYw==)
 | `97.5% <100%> (+0.06%)` | :arrow_up: |
   | 
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
 | `66.83% <0%> (-0.51%)` | :arrow_down: |
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `94.11% <0%> (-0.26%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `92.63% <0%> (-0.25%)` | :arrow_down: |
   | 
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
 | `86.36% <0%> (-0.13%)` | :arrow_down: |
   | 
[tests/field\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-dGVzdHMvZmllbGRfdGVzdC5j)
 | `79.56% <0%> (ø)` | :arrow_up: |
   | 
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
 | `88.19% <0%> (+0.01%)` | :arrow_up: |
   | 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `94.35% <0%> (+0.11%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/qpid-dispatch/pull/543/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=footer).
 Last update 
[f0dae4c...5b0802b](https://codecov.io/gh/apache/qpid-dispatch/pull/543?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> qd_buffer_list_clone is copying too much data
> ---------------------------------------------
>
>                 Key: DISPATCH-1390
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1390
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Francesco Nigro
>            Priority: Major
>
> qd_buffer_list_clone is ignoring the size of the src buffer and always copy 
> the entire capacity
> of it into the destination buffer.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to