[
https://issues.apache.org/jira/browse/QPID-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928640#comment-16928640
]
ASF GitHub Bot commented on QPID-7615:
--------------------------------------
alex-rufous commented on pull request #34: QPID-7615 Number of selectors can be
equal to connection thread pool size
URL: https://github.com/apache/qpid-broker-j/pull/34#discussion_r323793431
##########
File path:
broker-core/src/test/java/org/apache/qpid/server/model/VirtualHostTest.java
##########
@@ -509,31 +509,47 @@ public void testExistingConnectionBlocking()
}
@Test
- public void testCreateValidation()
+ public void testSelectorNumberMustBePositiveOnCreate()
{
+ createVirtualHost(getTestName(),
Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "1"));
try
{
- createVirtualHost(getTestName(),
Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS,
- "-1"));
- fail("Exception not thrown for negative number of selectors");
+ createVirtualHost(getTestName(),
Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "0"));
+ fail("Exception not thrown for non-positive number of selectors");
}
catch (IllegalConfigurationException e)
{
// pass
}
+ }
+
+ @Test
+ public void testConnectionThreadPoolSizeMustBePositiveOnCreate()
Review comment:
Please, split method into positive and negative tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot set number of selectors equal to pool size
> -------------------------------------------------
>
> Key: QPID-7615
> URL: https://issues.apache.org/jira/browse/QPID-7615
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
> Affects Versions: qpid-java-6.1.1
> Reporter: James Howe
> Priority: Minor
>
> For both Port and VirtualHost, the number of selectors is required to be
> strictly less than the pool size.
> In particular, this means a pool size of 1 is not possible, as would be
> desired for a minimal embedded/test configuration.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
