ssorj commented on a change in pull request #192: Changed Python API to better
handle strings where symbo…
URL: https://github.com/apache/qpid-proton/pull/192#discussion_r333153614
##########
File path: python/proton/_message.py
##########
@@ -440,8 +465,8 @@ def _set_annotations(self, annotations):
annotations = property(_get_annotations, _set_annotations, doc="""
Message annotations as a dictionary of key/values. The AMQP 1.0
specification restricts this dictionary to have keys that are either
- :class:`symbol` or :class:`ulong` types. It is recommended that
- the special ``dict`` subclass :class:`AnnotationDict` is used as it
+ :class:`symbol` or :class:`ulong` types. It is possible to use
+ the special ``dict`` subclass :class:`AnnotationDict` as it
Review comment:
"It is possible to do X if you wish to achieve Y", or something like that.
"It is possible to do X as it does Y" doesn't work for me. I think the idea is
to use it if you want the behavior, not because of the behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
