[
https://issues.apache.org/jira/browse/PROTON-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964085#comment-16964085
]
ASF GitHub Bot commented on PROTON-2030:
----------------------------------------
jdanekrh commented on pull request #180: PROTON-2030 Use CLOCK_MONOTONIC in
proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341169458
##########
File path: c/src/proactor/win_iocp.c
##########
@@ -1968,9 +1955,9 @@ class reaper {
// Call with lock
if (timer_ || !running)
return;
- pn_timestamp_t now = pn_i_now2();
+ int64_t now = pn_proactor_now_64();
pni_zombie_check(iocp_, now);
- pn_timestamp_t zd = pni_zombie_deadline(iocp_);
+ int64_t zd = pni_zombie_deadline(iocp_);
if (zd) {
DWORD tm = (zd > now) ? zd - now : 1;
Review comment:
Here the subtraction will not wraparound, so I am not touching it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use CLOCK_MONOTONIC in proactors for pn_transport_tick
> ------------------------------------------------------
>
> Key: PROTON-2030
> URL: https://issues.apache.org/jira/browse/PROTON-2030
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.27.0
> Reporter: Jiri Daněk
> Priority: Major
>
> IOCP and epoll proactors are feeding wall clock time to pn_transport_tick. I
> tested (with epoll) that changing system clock breaks heartbeating.
> The libuv proactor does use monotonic already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
