[ https://issues.apache.org/jira/browse/DISPATCH-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975163#comment-16975163 ]
ASF GitHub Bot commented on DISPATCH-1480: ------------------------------------------ kgiusti commented on pull request #619: DISPATCH-1480: properly settle messages received by the edge address … URL: https://github.com/apache/qpid-dispatch/pull/619#discussion_r346868641 ########## File path: src/router_core/modules/edge_router/addr_proxy.c ########## @@ -460,8 +461,14 @@ static void on_transfer(void *link_context, qd_parse_free(body); qd_iterator_free(iter); + } else { + qd_log(ap->core->log, QD_LOG_WARNING, + "Edge Address Proxy: received an invalid message body, rejecting"); + dispo = PN_REJECTED; } + qdrc_endpoint_settle_CT(ap->core, dlv, dispo); Review comment: Turns out that all messages sent to this client are PRE-settled, so setting the disposition to PN_REJECTED is harmless. I think this patch is good to go. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Address Sanitizer leak in system_tests_multi_phase > -------------------------------------------------- > > Key: DISPATCH-1480 > URL: https://issues.apache.org/jira/browse/DISPATCH-1480 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tests > Reporter: Ganesh Murthy > Assignee: Ken Giusti > Priority: Major > > {noformat} > 57: Test command: /usr/bin/python > "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest" > "-v" "system_tests_multi_phase"57: Test timeout computed to be: 60057: > test_01_waypoint_same_interior (system_tests_multi_phase.RouterTest) ... > ok57: test_02_waypoint_same_edge (system_tests_multi_phase.RouterTest) ... > ok57: test_03_waypoint_edge_interior (system_tests_multi_phase.RouterTest) > ... ok57: test_04_waypoint_interior_edge > (system_tests_multi_phase.RouterTest) ... ok57: > test_05_waypoint_interior_interior (system_tests_multi_phase.RouterTest) ... > ok57: test_06_waypoint_edge_edge (system_tests_multi_phase.RouterTest) ... > ok57: test_07_waypoint_edge_endpoints_int_1 > (system_tests_multi_phase.RouterTest) ... ok57: > test_08_waypoint_edge_endpoints_int_2 (system_tests_multi_phase.RouterTest) > ... ok57: test_09_waypoint_int_endpoints_edge_1 > (system_tests_multi_phase.RouterTest) ... ok57: > test_10_waypoint_int_endpoints_edge_2 (system_tests_multi_phase.RouterTest) > ... ok57: test_11_waypoint_int_endpoints_int_1 > (system_tests_multi_phase.RouterTest) ... ok57: > test_12_waypoint_int_endpoints_int_2 (system_tests_multi_phase.RouterTest) > ... ok57: test_13_waypoint_edge_endpoints_edge_1 > (system_tests_multi_phase.RouterTest) ... ok57: > test_14_waypoint_edge_endpoints_edge_2 (system_tests_multi_phase.RouterTest) > ... ok57: test_15_multiphase_1 (system_tests_multi_phase.RouterTest) ... > ok57: test_16_multiphase_2 (system_tests_multi_phase.RouterTest) ... ok57: > test_17_multiphase_3 (system_tests_multi_phase.RouterTest) ... ok57: ERROR57: > 57: ======================================================================57: > ERROR: tearDownClass (system_tests_multi_phase.RouterTest)57: > ----------------------------------------------------------------------57: > Traceback (most recent call last):57: File > "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 670, in > tearDownClass57: cls.tester.teardown()57: File > "/home/travis/build/apache/qpid-dispatch/tests/system_test.py", line 615, in > teardown57: raise RuntimeError("Errors during teardown: \n\n%s" % > "\n\n".join([str(e) for e in errors]))57: RuntimeError: Errors during > teardown: {noformat} > 57: Process 13237 error: exit code 23, expected 0 > > 57: qdrouterd -c EA1.conf -I /home/travis/build/apache/qpid-dispatch/python > > 57: > /home/travis/build/apache/qpid-dispatch/build/tests/system_test.dir/system_tests_multi_phase/RouterTest/setUpClass/EA1-3.cmd > > 57: >>>> > > 57: > > 57: ================================================================= > > 57: ==13237==ERROR: LeakSanitizer: detected memory leaks > > 57: > > 57: Indirect leak of 1728 byte(s) in 3 object(s) allocated from: > > 57: #0 0x7fd4cbb67076 in __interceptor_posix_memalign > (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x99076) > > 57: #1 0x7fd4cb47fac8 in qd_alloc > /home/travis/build/apache/qpid-dispatch/src/alloc_pool.c:320 > > 57: #2 0x7fd4cb489b1d in qd_buffer > /home/travis/build/apache/qpid-dispatch/src/buffer.c:44 > > 57: #3 0x7fd4cb49b7f4 in qd_insert > /home/travis/build/apache/qpid-dispatch/src/compose.c:64 > > 57: #4 0x7fd4cb49b7f4 in qd_insert_8 > /home/travis/build/apache/qpid-dispatch/src/compose.c:85 > > 57: #5 0x7fd4cb49b7f4 in qd_compose > /home/travis/build/apache/qpid-dispatch/src/compose.c:230 > > 57: #6 0x7fd4cb51c0b6 in qcm_link_route_lookup_request > /home/travis/build/apache/qpid-dispatch/src/address_lookup_utils.c:36 > > 57: #7 0x7fd4cb5cfd25 in qcm_addr_lookup_process_pending_requests_CT > /home/travis/build/apache/qpid-dispatch/src/router_core/modules/address_lookup_client/lookup_client.c:487 > > 57: #8 0x7fd4cb5d17ff in on_flow > /home/travis/build/apache/qpid-dispatch/src/router_core/modules/address_lookup_client/lookup_client.c:626 > > 57: #9 0x7fd4cb558928 in _sender_flow_CT > /home/travis/build/apache/qpid-dispatch/src/router_core/core_client_api.c:450 > > 57: #10 0x7fd4cb5b16d7 in qdr_link_flow_CT > /home/travis/build/apache/qpid-dispatch/src/router_core/transfer.c:331 > > 57: #11 0x7fd4cb59700b in router_core_thread > /home/travis/build/apache/qpid-dispatch/src/router_core/router_core_thread.c:194 > > 57: #12 0x7fd4cb02c6b9 in start_thread > (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9) > > 57: > > 57: ----------------------------------------------------- > > 57: Suppressions used: > > 57: count bytes template > > 57: 7 4288 _flush_send_queue_CT > > 57: 2 1152 compose_message_annotations > > 57: 7 4032 qd_compose_insert_string_n > > 57: 57 25920 qd_message_receive > > 57: 3 1200 qdr_core_subscribe > > 57: 20 7040 qdr_forward_balanced_CT > > 57: 14 4480 qdr_link_deliver > > 57: 3 1728 qdr_terminus > > 57: 4379 3269630 *libpython* > > 57: 37 120 *python2* > > 57: ----------------------------------------------------- > > 57: > > 57: SUMMARY: AddressSanitizer: 1728 byte(s) leaked in 3 allocation(s). > 57: <<<< -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org