astitcher commented on a change in pull request #213: PROTON-2140: Lazy
creation of various link related objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349301002
##########
File path: c/src/core/engine.c
##########
@@ -203,9 +204,9 @@ pn_transport_t *pn_connection_transport(pn_connection_t
*connection)
void pn_condition_init(pn_condition_t *condition)
{
- condition->name = pn_string(NULL);
- condition->description = pn_string(NULL);
- condition->info = pn_data(0);
+ condition->name = NULL;
+ condition->description = NULL;
+ condition->info = pni_data(0, 0);
Review comment:
Why not lazily create `condition->info` the data is still somewhat large and
info is hardly ever used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
