[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980221#comment-16980221
]
ASF GitHub Bot commented on DISPATCH-1488:
------------------------------------------
codecov-io commented on issue #625: DISPATCH-1488: properly forward tranaction
coordinator disposition data
URL: https://github.com/apache/qpid-dispatch/pull/625#issuecomment-557567672
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=h1)
Report
> Merging
[#625](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/40303c20834ab4ec8ef8c1c8afa548b29c8a13da?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
+ Coverage 86.44% 86.47% +0.02%
==========================================
Files 91 91
Lines 20625 20625
==========================================
+ Hits 17830 17835 +5
+ Misses 2795 2790 -5
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/625/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.61% <100%> (-0.5%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/625/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `89.32% <37.5%> (+0.79%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/625/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.09% <0%> (ø)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/625/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.31% <0%> (+0.11%)` | :arrow_up: |
|
[src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/625/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=)
| `87.86% <0%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/625/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `68.59% <0%> (+0.48%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=footer).
Last update
[40303c2...a331042](https://codecov.io/gh/apache/qpid-dispatch/pull/625?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> link-routed transaction coordination broken due to 'declared' state truncation
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 1.9.0, 1.10.0
> Reporter: Robbie Gemmell
> Assignee: Ken Giusti
> Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the txn-id from the delivery
> state:
> {noformat}
> [0x21ddf40]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"4a12a39a-09fe-11ea-91ae-000c29e9f622"]]
> [0x2251560]:1 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) null]
> {noformat}
> The recipient client then barfs at this point since txn-id is mandatory for
> the declared state.
> Using 1.8.0, the declared state transited the router fine:
> {noformat}
> [0x1f49530]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> [0x1fc2b20]:2 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
