[ https://issues.apache.org/jira/browse/PROTON-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980281#comment-16980281 ]
ASF GitHub Bot commented on PROTON-2138: ---------------------------------------- astitcher commented on issue #209: PROTON-2138: properly parse the remote terminus properties URL: https://github.com/apache/qpid-proton/pull/209#issuecomment-557593244 I don't currently have the protocol knowledge to fully review this change. I'd feel a lot more comfortable with it if there was a a test added that would fail with the current code and succeed with this change. (Probably in the python tests) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Capabilities not present in transaction coordinator attach > ---------------------------------------------------------- > > Key: PROTON-2138 > URL: https://issues.apache.org/jira/browse/PROTON-2138 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c > Affects Versions: proton-c-0.29.0 > Reporter: Ken Giusti > Assignee: Ken Giusti > Priority: Major > Fix For: proton-c-0.30.0 > > > When paring an incoming ATTACH frame for a transaction coordinator Proton > does not correctly retrieve the coordinator target's capabilities field. > Here's a trace from qpid-dispatch servicing a request between tx_send.py and > artemis: > This attach frame arrives from tx_send.py: > {noformat} > 2019-11-20 11:39:25.133485 -0500 SERVER (trace) [2]:FRAME: 0 <- @attach(18) > [name="txn-ctrl", handle=1, role=false, snd-settle-mode=2, rcv-settle-mode=0, > source=@source(40) [durable=0, timeout=0, dynamic=false], > target=@coordinator(48) [capabilities=:"amqp:local-transactions"], > initial-delivery-count=0] > {noformat} > Note the " [capabilities=:"amqp:local-transactions"]" in the target. > On dispatch attempting to retrieve the target's capabilities return no data: > 2019-11-20 11:39:25.133710 -0500 ROUTER (info) KAG: qdr-target= -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org