[ https://issues.apache.org/jira/browse/DISPATCH-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983973#comment-16983973 ]
ASF GitHub Bot commented on DISPATCH-1499: ------------------------------------------ codecov-io commented on issue #634: DISPATCH-1499: Make qd_policy_settings_t a managed type URL: https://github.com/apache/qpid-dispatch/pull/634#issuecomment-559269819 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=h1) Report > Merging [#634](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/9f7bb192e57019385296808fdb2f5c1edf03f909?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/634/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #634 +/- ## ========================================== + Coverage 86.48% 86.49% +0.01% ========================================== Files 91 91 Lines 20628 20629 +1 ========================================== + Hits 17841 17844 +3 + Misses 2787 2785 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/634/diff?src=pr&el=tree#diff-c3JjL3BvbGljeS5j) | `87.07% <100%> (+0.01%)` | :arrow_up: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/634/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `84.23% <100%> (ø)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/634/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.36% <0%> (-0.5%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/634/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.21% <0%> (+0.11%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/634/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.43% <0%> (+0.33%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=footer). Last update [9f7bb19...a79e60d](https://codecov.io/gh/apache/qpid-dispatch/pull/634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Policy settings objects should be in managed pool > ------------------------------------------------- > > Key: DISPATCH-1499 > URL: https://issues.apache.org/jira/browse/DISPATCH-1499 > Project: Qpid Dispatch > Issue Type: Bug > Components: Policy Engine > Affects Versions: 1.9.0 > Reporter: Charles E. Rolke > Assignee: Charles E. Rolke > Priority: Major > > Instead they are handled with malloc and free on a per-connection basis. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org