alex-rufous commented on issue #44: QPID-8367 [Broker-J] Trusted CA revocation list URL: https://github.com/apache/qpid-broker-j/pull/44#issuecomment-578801454 Hi Tomas, Thanks for addressing my review comments. My apologies for the delay with applying this pull request. I have an additional question to the implementation of `org.apache.qpid.server.security.AbstractTrustStore#getParameters`. If attribute 'certificateRevocationListUrl' is set, the other certificate revocation check attributes are ignored. Why is that? I cannot find in documentation that `java.security.cert.PKIXParameters#addCertStore` and `java.security.cert.PKIXParameters#addCertPathChecker` are mutually exclusive. It looks like we should be able to add `PKIXRevocationChecker` together with not null CLR. Am I missing something here? Kind Regards, Alex
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
