[
https://issues.apache.org/jira/browse/DISPATCH-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032639#comment-17032639
]
ASF subversion and git services commented on DISPATCH-1559:
-----------------------------------------------------------
Commit b282a284d6853acd14386f33a60d8b079dec93ec in qpid-dispatch's branch
refs/heads/master from Charles E. Rolke
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=b282a28 ]
NO-JIRA: Instrument MessageRouteAbortTest; use new test Logger
This patch adds debugability to system_tests_delivery_abort.
- Every test message is a different length
- Test message content is unique - a string of the message length
- Logging statements track test progress
A major frustration is a failure like DISPATCH-1559: some test fails
intermittently and the results of the assertion that fails the test is
*truncated*. It is an even harder problem when the failure is on some
remote CI system over which one has no control.
This patch is essentially the debug scaffolding that was required to
debug DISPATCH-1559. This patch uses the Logger added in DISPATCH-1536.
The log holds a narrative of exactly when (to the uS) each message was
sent or aborted from the client's view. Armed with this one can then
look into the router logs to see AMQP progress and diagnose the fault.
> Delivery_abort test fails by streaming multiple messages into one
> -----------------------------------------------------------------
>
> Key: DISPATCH-1559
> URL: https://issues.apache.org/jira/browse/DISPATCH-1559
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.10.0
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
> Fix For: 1.11.0
>
>
> MessageRouteAbortTest sends four 10-byte messages that get delivered to the
> client. In the meantime the test has moved on to streaming a 100,000 byte
> message to be aborted. When the first 10-byte message arrives it calls send()
> which streams another 100,000 byte message. on_message gets called a couple
> of times before on_sendable gets back to aborting the current delivery. Now
> all the streamed message content to be aborted is in one delivery and the
> test fails.
> The fix is to modify send() not to blindly send the next programmed message.
> If it observes that a message-to-be-aborted is in flight then it simply exits.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
