kgiusti commented on a change in pull request #676: DISPATCH-1518: Added ability to turn on protocol frame trace logging … URL: https://github.com/apache/qpid-dispatch/pull/676#discussion_r377655039
########## File path: python/qpid_dispatch/management/client.py ########## @@ -76,6 +76,16 @@ def delete(self): class Node(object): """Client proxy for an AMQP management node""" + def clean_attrs(self, attrs): + BOOL_VALUES = {"yes": 1, "true": 1, "on": 1, "no": 0, "false": 0, Review comment: What about case? Is 'Yes' true or only 'yes'? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org