ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569:
add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378355488
##########
File path: tools/qdstat.in
##########
@@ -728,6 +743,17 @@ class BusManager(Node):
dispRows = sorter.getSorted()
disp.formattedTable(title, heads, dispRows)
+ # attempt to get the qdrouterd process memory usage
+ # this may not be present on all platforms
+ try:
+ objects = self.query('org.apache.qpid.dispatch.router',
['memoryUsage'])
+ mem = objects[0].memoryUsage
+ except Exception:
+ mem = 0
+
+ if mem != 0:
+ print("\nProcess memory usage: %s" % self._mem_as_mb_str(mem))
Review comment:
This doesn't print the MB unit specifier as in the -g table
This doesn't quote the values when --csv is in effect. I'd expect "Process
memory usage:","520.2 MB" in that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
