[
https://issues.apache.org/jira/browse/DISPATCH-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036481#comment-17036481
]
ASF GitHub Bot commented on DISPATCH-1564:
------------------------------------------
kgiusti commented on pull request #682: DISPATCH-1564 - Modified the way ulong
is displayed on the output of …
URL: https://github.com/apache/qpid-dispatch/pull/682#discussion_r379099545
##########
File path: python/qpid_dispatch_internal/tools/display.py
##########
@@ -138,6 +143,33 @@ def num(self, value):
value /= 1000
return self.numCell(value, 'g')
+def PlainNum(value):
Review comment:
Is the precision check even necessary since the return string will be the
minimum size in any case? Could PlainNum simply return "%d" % value ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Two system tests fail on Fedora 32(fedora:rawhide)
> --------------------------------------------------
>
> Key: DISPATCH-1564
> URL: https://issues.apache.org/jira/browse/DISPATCH-1564
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.10.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> {noformat}
> 22: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_default_distribution"
> 22: Test timeout computed to be: 600
> 22: test_anonymous_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_receiver
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_create_unavailable_sender
> (system_tests_default_distribution.DefaultDistributionTest) ... ok
> 22: test_general (system_tests_default_distribution.DefaultDistributionTest)
> ... FAIL
> 22:
> 22: ======================================================================
> 22: FAIL: test_general
> (system_tests_default_distribution.DefaultDistributionTest)
> 22: ----------------------------------------------------------------------
> 22: Traceback (most recent call last):
> 22: File "/main/qpid-dispatch/tests/system_tests_default_distribution.py",
> line 83, in test_general
> 22: self.assertTrue("Connections 1" in out)
> 22: AssertionError: False is not true
> {noformat}
> Another test failure
>
> {noformat}
> 28: Test command: /usr/bin/python "/main/qpid-dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_qdstat"
> 28: Test timeout computed to be: 600
> 28: test_all_entities (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_all_routers_csv
> (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_all_entities_csv (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_link_priority_csv (system_tests_qdstat.QdstatLinkPriorityTest) ...
> ERROR
> 28: test_links_all_routers (system_tests_qdstat.QdstatLinkPriorityTest) ... ok
> 28: test_links_all_routers_csv (system_tests_qdstat.QdstatLinkPriorityTest)
> ... ok
> 28: test_ssl_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth_fail_no_sasl_external
> (system_tests_qdstat.QdstatSslNoExternalTest) ... ok
> 28: test_ssl_bad_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_bad_trustfile_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_bad_trustfile_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_cert_explicit_external_to_auth
> (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_cert_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_none_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_schema_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_scheme_to_none (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_cert_to_strict (system_tests_qdstat.QdstatSslTest) ...
> ok
> 28: test_ssl_trustfile_cert_to_unsecured (system_tests_qdstat.QdstatSslTest)
> ... ok
> 28: test_ssl_trustfile_to_auth (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_to_strict (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_trustfile_to_unsecured (system_tests_qdstat.QdstatSslTest) ... ok
> 28: test_ssl_bad_trustfile_to_auth
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_bad_trustfile_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_bad_trustfile_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_cert_explicit_external_to_auth
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_cert_to_auth (system_tests_qdstat.QdstatSslTestSslPasswordFile)
> ... ok
> 28: test_ssl_cert_to_none (system_tests_qdstat.QdstatSslTestSslPasswordFile)
> ... ok
> 28: test_ssl_cert_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_cert_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_none (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_none_to_auth (system_tests_qdstat.QdstatSslTestSslPasswordFile)
> ... ok
> 28: test_ssl_none_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_none_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_schema_to_auth
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_schema_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_schema_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_scheme_to_none
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_trustfile_cert_to_auth
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_trustfile_cert_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_trustfile_cert_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_trustfile_to_auth
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_trustfile_to_strict
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_ssl_trustfile_to_unsecured
> (system_tests_qdstat.QdstatSslTestSslPasswordFile) ... ok
> 28: test_address (system_tests_qdstat.QdstatTest) ... ok
> 28: test_address_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_address_priority (system_tests_qdstat.QdstatTest) ... ok
> 28: test_address_priority_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_address_with_limit (system_tests_qdstat.QdstatTest) ... ok
> 28: test_address_with_limit_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_connections (system_tests_qdstat.QdstatTest) ... ok
> 28: test_connections_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_general (system_tests_qdstat.QdstatTest) ... FAIL
> 28: test_general_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_help (system_tests_qdstat.QdstatTest) ... ok
> 28: test_links (system_tests_qdstat.QdstatTest) ... ok
> 28: test_links_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_links_with_limit (system_tests_qdstat.QdstatTest) ... ok
> 28: test_links_with_limit_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_log (system_tests_qdstat.QdstatTest) ... ok
> 28: test_memory (system_tests_qdstat.QdstatTest) ... FAIL
> 28: test_memory_csv (system_tests_qdstat.QdstatTest) ... FAIL
> 28: test_nodes (system_tests_qdstat.QdstatTest) ... ok
> 28: test_nodes_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_qdstat_no_args (system_tests_qdstat.QdstatTest) ... ok
> 28: test_qdstat_no_other_args_csv (system_tests_qdstat.QdstatTest) ... ok
> 28: test_yy_query_many_links (system_tests_qdstat.QdstatTest) ... ok
> 28:
> 28: ======================================================================
> 28: ERROR: test_link_priority_csv (system_tests_qdstat.QdstatLinkPriorityTest)
> 28: ----------------------------------------------------------------------
> 28: Traceback (most recent call last):
> 28: File "/main/qpid-dispatch/tests/system_tests_qdstat.py", line 529, in
> test_link_priority_csv
> 28: priority = int(pri)
> 28: ValueError: invalid literal for int() with base 10: 'uint(0)'
> 28:
> 28: ======================================================================
> 28: FAIL: test_general (system_tests_qdstat.QdstatTest)
> 28: ----------------------------------------------------------------------
> 28: Traceback (most recent call last):
> 28: File "/main/qpid-dispatch/tests/system_tests_qdstat.py", line 69, in
> test_general
> 28: self.assertTrue("Connections 1" in out)
> 28: AssertionError: False is not true
> 28:
> 28: ======================================================================
> 28: FAIL: test_memory (system_tests_qdstat.QdstatTest)
> 28: ----------------------------------------------------------------------
> 28: Traceback (most recent call last):
> 28: File "/main/qpid-dispatch/tests/system_tests_qdstat.py", line 234, in
> test_memory
> 28: assert re.search(regexp, out, re.I), "Can't find '%s' in '%s'" %
> (regexp, out)
> 28: AssertionError: Can't find 'qdr_address_t\s+[0-9]+' in '2020-02-05
> 09:32:44.801662 UTC
> 28: QDR.A
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
