[
https://issues.apache.org/jira/browse/DISPATCH-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038471#comment-17038471
]
ASF GitHub Bot commented on DISPATCH-1566:
------------------------------------------
codecov-io commented on issue #679: DISPATCH-1566: fix safe_snptrintf
URL: https://github.com/apache/qpid-dispatch/pull/679#issuecomment-587058845
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=h1)
Report
> Merging
[#679](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc)
will **increase** coverage by `0.06%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #679 +/- ##
=========================================
+ Coverage 86.83% 86.9% +0.06%
=========================================
Files 92 92
Lines 21047 21131 +84
=========================================
+ Hits 18277 18363 +86
+ Misses 2770 2768 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/terminus.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3Rlcm1pbnVzLmM=)
| `87.73% <63.63%> (-1.24%)` | :arrow_down: |
|
[src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j)
| `90.42% <0%> (-0.59%)` | :arrow_down: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `79.94% <0%> (-0.59%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.41% <0%> (-0.49%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.61% <0%> (-0.3%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.09% <0%> (-0.15%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j)
| `86.81% <0%> (+0.06%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.35% <0%> (+0.18%)` | :arrow_up: |
|
[src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL2xvZy5j)
| `90.42% <0%> (+0.19%)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.22% <0%> (+0.56%)` | :arrow_up: |
| ... and [4
more](https://codecov.io/gh/apache/qpid-dispatch/pull/679/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=footer).
Last update
[b282a28...ed9b7c9](https://codecov.io/gh/apache/qpid-dispatch/pull/679?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> safe_snpritf is not safe.
> -------------------------
>
> Key: DISPATCH-1566
> URL: https://issues.apache.org/jira/browse/DISPATCH-1566
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node
> Affects Versions: 1.10.0
> Reporter: Nicolas
> Priority: Major
> Fix For: 1.11.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> {{/* **************************************** */}}
> {{static inline int safe_snprintf(char *str, size_t size, const char *format,
> ...)}}
> {{{ .... }}{{}}}
> This function fails for size = 0, and ... inside it calls vsnprintf, without
> considering that in case of error vsnprintf returns a negative number.
> PR in progress.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
