nicob87 commented on a change in pull request #684: WIP: (Work In Progress)
DISPATCH-1568: using doctest
URL: https://github.com/apache/qpid-dispatch/pull/684#discussion_r381019059
##########
File path: src/router_core/terminus.c
##########
@@ -75,25 +76,47 @@ void qdr_terminus_free(qdr_terminus_t *term)
free_qdr_terminus_t(term);
}
+#ifdef TESTING
+__attribute__((weak))
Review comment:
no need to make it weak since this goes to a shared library.
__attribute__((noinline)) probably is a good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
