[ 
https://issues.apache.org/jira/browse/PROTON-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046377#comment-17046377
 ] 

Robert Godfrey edited comment on PROTON-2108 at 2/27/20 9:20 AM:
-----------------------------------------------------------------

[~jross] what it says is what the authors intended.  Note that the set of 
outcomes is open, implementers are free to define their own outcomes in 
addition to those outlined in the spec, thus a definition along the lines that 
[~gsim] proposed above _"any of the outcomes are valid"_ would mean that it is 
implicitly saying that it will accept the new outcome 
"send_me_helium_filled_elephants" that I have just invented :).  I don't intend 
to suggest that leaving the outcomes open for extension wasn't a 
mistake/confusing, but the definition of supported/default outcome was 
specifically crafted to account for these circumstances.


was (Author: rgodfrey):
[~jross] what it says is what the authors intended.  Note that the set of 
outcomes is open, implementers are free to define their own outcomes in 
addition to those outlined in the spec, thus a definition along the lines that 
[~gsim] proposed above _"any of the outcomes are valid"_ would mean that it is 
implicitly saying that it will accept the new outcome 
"send_me_helium_filled_elephants" that I have just invented :).  I don't intend 
to suggest that leaving the outcomes open for extension wasn't a 
mistake/confusing, but the definition of default outcome was specifically 
crafted to account for these circumstances.

> supported source outcomes not set
> ---------------------------------
>
>                 Key: PROTON-2108
>                 URL: https://issues.apache.org/jira/browse/PROTON-2108
>             Project: Qpid Proton
>          Issue Type: Bug
>    Affects Versions: proton-c-0.29.0
>            Reporter: Robbie Gemmell
>            Priority: Critical
>
> From looking at some recent traces, it appears that the bindings (at least 
> for python, but probably others) do no set the outcomes (or default-outcome) 
> field on its source terminus, although they do use/support all the outcomes. 
> To a peer that actually inspects the outcomes to influence behaviour this 
> strictly means only Accepted is supported, which can lead to issues (e.g it 
> might accept a message then drop it, rather than release/modify/reject it, 
> under cases it couldn't be processed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to