[
https://issues.apache.org/jira/browse/DISPATCH-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084280#comment-17084280
]
ASF GitHub Bot commented on DISPATCH-975:
-----------------------------------------
gemmellr commented on pull request #717: DISPATCH-975: Enforce max message size
on message ingress
URL: https://github.com/apache/qpid-dispatch/pull/717#discussion_r409024595
##########
File path: src/amqp.c
##########
@@ -86,6 +86,7 @@ const char * const QD_AMQP_COND_RESOURCE_DELETED =
"amqp:resource-deleted";
const char * const QD_AMQP_COND_ILLEGAL_STATE = "amqp:illegal-state";
const char * const QD_AMQP_COND_FRAME_SIZE_TOO_SMALL =
"amqp:frame-size-too-small";
const char * const QD_AMQP_COND_CONNECTION_FORCED = "amqp:connection:forced";
+const char * const QD_AMQP_COND_MESSAGE_SIZE_EXCEEDED =
"amqp:connection:message-size-exceeded";
Review comment:
Its arguably not that big a deal to the sending client, as anyone sending
over the limit is going to have issues either way.
I was more curious given the commentry seems to suggest inter-router
connections could be getting killed too in certain cases, which could affect
other things besides the one doing the send? Or is that not the case? Though I
guess that effect may still be true of link closure too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Policy has no provision for limiting user message size
> ------------------------------------------------------
>
> Key: DISPATCH-975
> URL: https://issues.apache.org/jira/browse/DISPATCH-975
> Project: Qpid Dispatch
> Issue Type: Bug
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
