[
https://issues.apache.org/jira/browse/PROTON-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090160#comment-17090160
]
ASF subversion and git services commented on PROTON-2195:
---------------------------------------------------------
Commit ae06b4180e924b392e1b816f97aada8591255b5a in qpid-proton's branch
refs/heads/master from Andrew Stitcher
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=ae06b41 ]
PROTON-2195: Finalise the proactor API around pn_event_batch_t
- Move pn_event_batch_t entirely into libqpid-proton-proactor
- Make the pn_event_batch_t implementation private
- Removed pn_event_batch_connection_driver() API as it is not used at all
and can't be used for anything.
> Tidy up/Finalise the API around proactor event batches
> ------------------------------------------------------
>
> Key: PROTON-2195
> URL: https://issues.apache.org/jira/browse/PROTON-2195
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.30.0
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
> Fix For: proton-c-0.31.0
>
>
> There are a number of issues with the {{pn_event_batch_t}} type in proton:
> * The {{pn_event_batch_t}} type should be a type whose details are private
> and only meaningful to the proactor because it is only the proactor API
> batches events for serialisation. However it is defined in the event.h header
> file and its only operation {{pn_event_batch_next()}} is actually in the
> proton core library.
> * The type is used internally in the connection_driver API which is in the
> proton core library. This use is unnecessary as the batches are never even
> exposed by the connection_driver API. Indeed it's hard to see what use the
> connection_driver could make of an event batch since it only knows about
> events from the proton core library which only returns events and never
> batches.
> The proactor and connection_driver APIs which are the ones affected are both
> marked as Unsettled APIs so these changes are currently acceptable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
