kgiusti commented on a change in pull request #732:
URL: https://github.com/apache/qpid-dispatch/pull/732#discussion_r421031191
##########
File path: src/router_core/route_control.c
##########
@@ -441,6 +454,9 @@ void qdr_route_del_link_route_CT(qdr_core_t *core,
qdr_link_route_t *lr)
}
}
+ if (lr->hash_handle)
+ qd_hash_remove_by_handle(core->addr_lr_al_hash, lr->hash_handle);
Review comment:
Do we need to keep the hash handle around after this?
If not consider freeing it now and zero the lr->hash_handle.
##########
File path: src/router_core/router_core.c
##########
@@ -678,6 +684,8 @@ void qdr_core_remove_address_config(qdr_core_t *core,
qdr_address_config_t *addr
qd_iterator_t *pattern = qd_iterator_string(addr->pattern, ITER_VIEW_ALL);
// Remove the address from the list and the parse tree
+ if (addr->hash_handle)
+ qd_hash_remove_by_handle(core->addr_lr_al_hash, addr->hash_handle);
Review comment:
ditto
##########
File path: src/router_core/route_control.c
##########
@@ -543,6 +570,9 @@ void qdr_route_del_auto_link_CT(qdr_core_t *core,
qdr_auto_link_t *al)
}
}
+ if (al->hash_handle)
+ qd_hash_remove_by_handle(core->addr_lr_al_hash, al->hash_handle);
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
