[
https://issues.apache.org/jira/browse/DISPATCH-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101108#comment-17101108
]
ASF GitHub Bot commented on DISPATCH-1637:
------------------------------------------
kgiusti commented on a change in pull request #732:
URL: https://github.com/apache/qpid-dispatch/pull/732#discussion_r421031191
##########
File path: src/router_core/route_control.c
##########
@@ -441,6 +454,9 @@ void qdr_route_del_link_route_CT(qdr_core_t *core,
qdr_link_route_t *lr)
}
}
+ if (lr->hash_handle)
+ qd_hash_remove_by_handle(core->addr_lr_al_hash, lr->hash_handle);
Review comment:
Do we need to keep the hash handle around after this?
If not consider freeing it now and zero the lr->hash_handle.
##########
File path: src/router_core/router_core.c
##########
@@ -678,6 +684,8 @@ void qdr_core_remove_address_config(qdr_core_t *core,
qdr_address_config_t *addr
qd_iterator_t *pattern = qd_iterator_string(addr->pattern, ITER_VIEW_ALL);
// Remove the address from the list and the parse tree
+ if (addr->hash_handle)
+ qd_hash_remove_by_handle(core->addr_lr_al_hash, addr->hash_handle);
Review comment:
ditto
##########
File path: src/router_core/route_control.c
##########
@@ -543,6 +570,9 @@ void qdr_route_del_auto_link_CT(qdr_core_t *core,
qdr_auto_link_t *al)
}
}
+ if (al->hash_handle)
+ qd_hash_remove_by_handle(core->addr_lr_al_hash, al->hash_handle);
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Adding new config address, autolinks and link routes become slower as more
> get added
> -------------------------------------------------------------------------------------
>
> Key: DISPATCH-1637
> URL: https://issues.apache.org/jira/browse/DISPATCH-1637
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 1.11.0
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.13.0
>
> Attachments: qdr_perf_core_369301_369302.svg
>
>
> Steps to reproduce -
> # Start the router with a default config file, nothing special
> # Run the following qdmanage command in a loop from 1 to 200,000
> ## qdmanage CREATE --type=address prefix=abc\{i} name=abc\{i}
> distribution=balanced waypoint=yes
> # watch qdstat -g
> # Over time, the rate at which the addresses get added comes to a crawl
> This happens for autoLinks and linkRoutes as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
