jiridanek commented on a change in pull request #744:
URL: https://github.com/apache/qpid-dispatch/pull/744#discussion_r432865162



##########
File path: src/connection_manager.c
##########
@@ -157,6 +160,7 @@ static qd_config_sasl_plugin_t 
*qd_find_sasl_plugin(qd_connection_manager_t *cm,
     return 0;
 }
 
+// XXX Should this move to server.c or its own server_config.c?
 void qd_server_config_free(qd_server_config_t *cf)
 {

Review comment:
       Btw, I hate having to create new files. I always feel like I am 
polluting someone's else carefully thought out layout...
   
   Bbtw, I thought that clang-format with the style selected would move all 
opening braces on the same line. Apparently not. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to