[
https://issues.apache.org/jira/browse/PROTON-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123852#comment-17123852
]
ASF GitHub Bot commented on PROTON-2125:
----------------------------------------
jiridanek edited a comment on pull request #254:
URL: https://github.com/apache/qpid-proton/pull/254#issuecomment-637568551
> Ok, in that case do we want to actually split that change out from this
one (as it definitely seems like it needs fixing) and create a separate matrix
element for bionic then as I'm guessing the intent was to test on both bionic
and xenial.
I don't know what the intention was. I think I introduced that bionic line
and it was by mistake ;( My deliberate suggestion now is to have xenial,
bionic, but mostly focal in the matrix, as proposed in #246.
> I think this fix (if we're going to use it at all) should be in the ruby
CMakeLists.txt.
That's what I wanted to specifically avoid touching. If I am setting options
in CMake, I might just as well monkeypatch the warning out of minitest, or
possibly even migrate the tests from the deprecated methods (and monkeypatch in
the modern methods when using the rhel 7 version of minitest).
Having quickly checked, it looks like `gem` is available as a package in
rhel 7. That possibly means that using newer version of minitest from gem,
instead of the packaged version, may be possible. Given that it is a test-only
dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annoying deprecation warning from Minitest in Ruby tests
> --------------------------------------------------------
>
> Key: PROTON-2125
> URL: https://issues.apache.org/jira/browse/PROTON-2125
> Project: Qpid Proton
> Issue Type: Test
> Affects Versions: proton-c-0.29.0
> Reporter: Jiri Daněk
> Priority: Trivial
>
> {noformat}
> 41: 0.00 s = .
> 41: A data object#test_0002_can hold a null = DEPRECATED: global use of
> must_equal from
> /home/travis/build/jdanekrh/qpid-proton/ruby/spec/data_spec.rb:38. Use
> _(obj).must_equal instead. This will fail in Minitest 6.
> 41: 0.00 s = .
> 41: A data object#test_0019_raises an error on a negative uint = DEPRECATED:
> global use of must_raise from
> /home/travis/build/jdanekrh/qpid-proton/ruby/spec/data_spec.rb:136. Use
> _(obj).must_raise instead. This will fail in Minitest 6.
> 41: 0.00 s = .
> 41:
> 41: Finished in 0.067732s, 1033.4849 runs/s, 4414.4571 assertions/s.
> 41:
> 41: 70 runs, 299 assertions, 0 failures, 0 errors, 0 skips
> 41/44 Test #41: ruby-data-spec ................... Passed 0.28 sec
> test 42
> Start 42: ruby-exception-handling-spec
> {noformat}
> In e.g. https://travis-ci.org/apache/qpid-proton/jobs/601930436
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
