kgiusti commented on a change in pull request #755:
URL: https://github.com/apache/qpid-dispatch/pull/755#discussion_r437458359
##########
File path: include/qpid/dispatch/iterator.h
##########
@@ -329,6 +329,11 @@ int qd_iterator_ncopy(qd_iterator_t *iter, unsigned char*
buffer, int n);
*/
unsigned char *qd_iterator_copy(qd_iterator_t *iter);
+/**
Review comment:
The original is documented as advancing the iterator past the data
copied out. I'm assuming that some codepath relies on that behavior.
I'll need to audit the existing use cases before we can be sure we can
safely make that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
