kgiusti commented on a change in pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770#discussion_r450937139



##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -1945,6 +1945,13 @@
                     "required": true,
                     "create": true
                 },
+                "aliases": {
+                    "type": "string",
+                    "description": "Alternate hostnames that share this vhost 
configuation. Hosts named in this attribute are treated as if this vhost was 
defined with the alias name in the vhost 'hostname' attribute. This attribute 
is implemented to help with multitennant configurations where multiple vhosts 
share a common configuration. The string is a comma- or space-separated list of 
literal hostnames or hostname patterns. A vhost aliases hostname must be unique 
across all vhost hostnames and all of their aliases.",

Review comment:
       spelling "multiteNNant"

##########
File path: python/qpid_dispatch_internal/policy/policy_manager.py
##########
@@ -169,6 +180,23 @@ def set_max_message_size(self, size):
         :return: none
         """
         self._policy_local.set_max_message_size(size)
+
+#
+#
+#
+def policy_lookup_vhost_alias(mgr, vhost):
+    """
+    Look up a user in the policy database
+    Called by C code
+    @param mgr:
+    @param user:

Review comment:
       remove unused params?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to