[ https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159045#comment-17159045 ]
Robert Godfrey commented on QPID-8455: -------------------------------------- [~orudyy] I worry the "alternative names" could lead to a maintenance nightmare, and the code to support it could be quite complicated. (Theoretically you'd need to add logic to check that the alternative names are not also used by actual attributes, etc). For derived attributes / statistics I think it is probably good enough to simply add deprecated duplicate methods in using the old names (and remove these after 1 further release). For setting the values, I think it is cleaner to simply up the model version and do an upgrade (for the 7.x versions we'd need to do a 7.2 , and have an upgrader from 7.0 to 7.2 in that code line. In the 8.0 and main branches we'd need to have upgrades from 8.0 and 7.2 to an 8.1 version (which would preclude going from 7.2 to 8.0, but I think that is OK). Obviously if you want to go to the effort of adding some sort of alternative names mechanism, feel free to - but I think this will end up being fairly complicated - and I don't imagine that there are many places where these values are being dynamically set via the APIs on a frequent basis > [Broker-J]Use allow/deny list terminology for existing attributes and context > variables > --------------------------------------------------------------------------------------- > > Key: QPID-8455 > URL: https://issues.apache.org/jira/browse/QPID-8455 > Project: Qpid > Issue Type: Improvement > Components: Broker-J > Reporter: Dedeepya > Priority: Major > Fix For: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9 > > > Rename attributes and context variables containing the term white/black list > to allow/deny list. > The names allow/deny list are more inlined with current industry naming > standards. > Example: > The port derived attributes tlsCipherSuiteWhiteList and > tlsCipherSuiteBlackList will have to be renamed to tlsCipherSuiteAllowList > and tlsCipherSuiteDenyList respectively. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org