[ 
https://issues.apache.org/jira/browse/QPID-8455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159072#comment-17159072
 ] 

Alex Rudyy edited comment on QPID-8455 at 7/16/20, 9:46 AM:
------------------------------------------------------------

[~rgodfrey], I completely agree that the renaming of attributes should happen 
in major/minor version. My problem is that I do not have capacity to maintain 
more than 2 branches. That's why I am reluctant to upgrade models to 7.2 and 
8.1 at this point, as that would give me a maintenance headache to port changes 
and do the releases for 8.0.x and 7.1.x in parallel with 8.1. and 7.2 for at 
least another year. I am a bit concern  that introduction of alternative names 
would add unnecessary complexity without giving much benefits. I was also 
contemplating the idea  of adding duplicated deprecated methods/fields for the 
old names. Perhaps, that would be the best route to take at this point. It 
seems it would allow to keep code a bit simpler and easier to maintain. On the 
next major/minor release we can remove old deprecated names.


was (Author: alex.rufous):
[~rgodfrey], I completely agree that the renaming of attributes should happen 
in major/minor version. My problem is that I do not have capacity to maintain 
more than 2 branches. That's why I am reluctant to upgrade models to 7.2 and 
8.1 at this point, as that would give me a maintenance headache to port changes 
and do the releases for 8.0.x and 7.1.x in parallel with 8.1. and 7.2 for at 
least another year. I am a bit concern  that introduction of alternative names 
would add unnecessary complexity without giving much benefits. I was also 
contemplating the idea  of adding duplicated deprecated methods/fields for the 
old names. Perhaps, that would be the best route to take at this point. At 
seems it would allow to keep code a bit simpler and easier to maintain. On the 
next major/minor release we can remove old deprecated names.

> [Broker-J]Use allow/deny list terminology for existing attributes and context 
> variables
> ---------------------------------------------------------------------------------------
>
>                 Key: QPID-8455
>                 URL: https://issues.apache.org/jira/browse/QPID-8455
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Dedeepya
>            Priority: Major
>             Fix For: qpid-java-broker-8.0.1, qpid-java-broker-7.1.9
>
>
> Rename attributes and context variables containing the term white/black list 
> to allow/deny list.
> The names allow/deny list are more inlined with current industry naming 
> standards.
> Example:
> The port derived attributes tlsCipherSuiteWhiteList and 
> tlsCipherSuiteBlackList will have to be renamed to tlsCipherSuiteAllowList 
> and tlsCipherSuiteDenyList respectively.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to