[
https://issues.apache.org/jira/browse/PROTON-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159493#comment-17159493
]
ASF GitHub Bot commented on PROTON-2247:
----------------------------------------
cliffjansen commented on pull request #265:
URL: https://github.com/apache/qpid-proton/pull/265#issuecomment-659671286
Very nice. +1 on the API.
pn_raw_connection_free is not yet implemented in the pull request and the
documentation about ownership of the raw connection is perhaps out of date, but
I presume you are already aware.
As an implementation detail, I wonder how you distinguish between an
internal wake and an external pn_raw_connection_wake(), given that you have
dispensed with the wake_count indicator (used for that purpose in the
pconnection).
For example, if an internal wake is generated in unassign_thread() within
pni_raw_connection_done(), it seems to me you will get a spurious
PN_RAW_CONNECTION_WAKE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [c] Proactor API to support 'raw' TCP connections using the proactor event
> loop
> -------------------------------------------------------------------------------
>
> Key: PROTON-2247
> URL: https://issues.apache.org/jira/browse/PROTON-2247
> Project: Qpid Proton
> Issue Type: New Feature
> Components: proton-c
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
> Fix For: proton-c-0.32.0
>
>
> There are applications that use amqp together with some other protocol (http
> for example). It is currently difficult to combine other TCP use with amqp
> use when using proton and the proactor.
> It will be useful to be able to combine using 'raw' TCP connections with AMQP
> connections in a single proactor event loop.
> This will allow you to write application combining multiple protocols with
> AMQP without having to use multiple event loops and hence probably threads.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
