jiridanek commented on a change in pull request #783:
URL: https://github.com/apache/qpid-dispatch/pull/783#discussion_r460826702



##########
File path: console/react/test_data/qdrService.mock.js
##########
@@ -60,17 +62,13 @@ export const mockService = ({ onSendMethod }) => {
             resolve();
           });
         },
-        startUpdating: () => {
-          return new Promise(resolve => {
-            resolve();
-          });
-        },

Review comment:
       That's what I've done, except I've organized it that startUpdating and 
stopUpdating are next to each other. The new line 52 reads `startUpdating: () 
=> new Promise(resolve => resolve()),` which is exactly what was here, except 
written as oneliner.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to