[
https://issues.apache.org/jira/browse/DISPATCH-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ernest Allen resolved DISPATCH-1727.
------------------------------------
Fix Version/s: 2.0.0
Resolution: Fixed
Copies the package-lock.json file into the build directory before the build so
that it is used for the build.
Makes the build dependent on package-lock.json and package.json so that if
either or them changes, the console will be rebuilt.
Note: I didn't change the required node version to 5.x (which is the minimum
version that supports package-lock.json). Those with version < 5.x will still
be able to build, but they won't get the benefit of the package-lock.json file.
> Dispatch Console mixes usage of `npm` with `yarn`
> -------------------------------------------------
>
> Key: DISPATCH-1727
> URL: https://issues.apache.org/jira/browse/DISPATCH-1727
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Console
> Affects Versions: 1.12.0
> Reporter: Jiri Daněk
> Assignee: Ernest Allen
> Priority: Critical
> Fix For: 2.0.0
>
>
> There is a `yarn.lock` file checked into the repository, but CMake build file
> is using straight `npm` to build the console.
> This means that the content of `yarn.lock` is used during Console development
> (if yarn is used to build and test the console) and it is ignored when CMake
> is building Dispatch Console for deployment.
> There is a package locking mechanism in npm since npm version 5. It is
> `package-lock.json`. We should decide if we want to use yarn or npm, and use
> the corresponding command in CMake, and use the correct lock file.
> The decision should take into account users of Dispatch, who may not have
> access to npm 5, possibly. I am not sure if this is relevant consideration.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
