[
https://issues.apache.org/jira/browse/DISPATCH-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167769#comment-17167769
]
ASF GitHub Bot commented on DISPATCH-1568:
------------------------------------------
gemmellr commented on pull request #684:
URL: https://github.com/apache/qpid-dispatch/pull/684#issuecomment-666255843
I think it would have been nice to squash the changes before pushing to the
repo, 6 (well, I just made a 7th :P) commits for this relatively
straightforward addition seems unecessary and complicates the history later for
no real gain, with e.g some changes adding and removed in the same push, and
the licence changes seperate from the changes that requires them.
If trying to preserve authorship then just 2 would have at least been
simpler. The original commits would still have remained here on the PR if they
were simply being 'saved' for future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add unittest framework for testing C code
> -----------------------------------------
>
> Key: DISPATCH-1568
> URL: https://issues.apache.org/jira/browse/DISPATCH-1568
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node, Tests
> Reporter: Nicolas
> Priority: Major
> Fix For: 1.13.0
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Right now we are not using any framework for easily write c unit-test when
> developing (or later).
> The idea is to research available libraries, pick one and try to include in
> our workflow.
> preliminary candidates:
> [https://github.com/google/googletest]
> [https://github.com/catchorg/Catch2]
> [https://github.com/catchorg/Catch2/tree/Catch1.x] <- Actually, Qpid Proton
> is using this one (old catch2)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
