ganeshmurthy commented on a change in pull request #803: URL: https://github.com/apache/qpid-dispatch/pull/803#discussion_r463758935
########## File path: src/router_core/connections.c ########## @@ -1381,6 +1381,10 @@ static void qdr_connection_opened_CT(qdr_core_t *core, qdr_action_t *action, boo qdrc_event_conn_raise(core, QDRC_EVENT_CONN_OPENED, conn); } + if (discard && conn) { Review comment: Thanks @kgiusti I have added code to check conn and discard at the top of the functions like other action routines and also dropped a level of indentation. The diff looks weird because of dropping one level of indentation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org