jiridanek commented on a change in pull request #806:
URL: https://github.com/apache/qpid-dispatch/pull/806#discussion_r463826667
##########
File path: tests/system_tests_protocol_settings.py
##########
@@ -245,7 +234,6 @@ def test_max_session_frames_default(self):
# if frame size not set then a default is used
self.assertTrue(" max-frame-size=16384" in open_lines[0])
begin_lines = [s for s in log_lines if "-> @begin" in s]
- # incoming-window is from the config
Review comment:
I'd instead explain where is the number coming from. Maybe
```# incoming-window is the Proton default```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
