[
https://issues.apache.org/jira/browse/DISPATCH-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169143#comment-17169143
]
ASF GitHub Bot commented on DISPATCH-1736:
------------------------------------------
jiridanek commented on a change in pull request #806:
URL: https://github.com/apache/qpid-dispatch/pull/806#discussion_r463826667
##########
File path: tests/system_tests_protocol_settings.py
##########
@@ -245,7 +234,6 @@ def test_max_session_frames_default(self):
# if frame size not set then a default is used
self.assertTrue(" max-frame-size=16384" in open_lines[0])
begin_lines = [s for s in log_lines if "-> @begin" in s]
- # incoming-window is from the config
Review comment:
I'd instead explain where is the number coming from. Maybe
```# incoming-window is the Proton default```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_protocol_settings should not skip any tests
> --------------------------------------------------------
>
> Key: DISPATCH-1736
> URL: https://issues.apache.org/jira/browse/DISPATCH-1736
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> As part of commit 4a173e1ec0f7e0e8f9d7d37b9549d4f9c9d37fb0, a skip_test flag
> was wrongly added to skip the tests on 32 bit machines. This flag must be
> removed and no tests must be skipped. This test should work on all arches 32
> and 64 bit
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
