[
https://issues.apache.org/jira/browse/DISPATCH-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170840#comment-17170840
]
Ganesh Murthy commented on DISPATCH-1728:
-----------------------------------------
The router tests (for example system_tests_sasl_plain.py) uses a proton python
binding function called SASL.extended() (which in turn calls
pn_sasl_extended()) to skip the tests like seen here -
[https://github.com/apache/qpid-dispatch/blob/master/tests/system_tests_sasl_plain.py#L80]
In Proton, in the cases where SASL libraries are not available, the
cyrus_stub.c is included as seen here
[https://github.com/apache/qpid-proton/blob/master/c/CMakeLists.txt#L100]
In the case here
[https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6] since proton
is directly installed, the SASL.extended() returns true and the Dispatch tests
start executing.
[~jross] Dispatch CMakeLists.txt must do the same thing as being done in the
Proton CMakeLists.txt to skip the tests instead of using Proton's
SASL.extended() function. Please let me know what you think.
> Enforce SASL dependency in build metadata
> -----------------------------------------
>
> Key: DISPATCH-1728
> URL: https://issues.apache.org/jira/browse/DISPATCH-1728
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Justin Ross
> Assignee: Ganesh Murthy
> Priority: Major
>
> The tests require Cyrus SASL and the SASL plain mechanism. Those should be
> expressed as dependencies in cmake or in a pre-test dependency check.
> Otherwise, you can build the project and start running the tests before you
> find out you are missing them.
> A dockerfile that shows the problem:
> https://gist.github.com/ssorj/80b79856ee233aab2067c88f967273f6
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
